Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.08%. Comparing base (248e741) to head (525971b).
⚠️ Report is 1 commits behind head on main.

@@            Coverage Diff             @@
##             main    #3209      +/-   ##
==========================================
- Coverage   97.09%   97.08%   -0.01%     
==========================================
  Files          56       56              
  Lines        9681     9687       +6     
  Branches     1753     1754       +1     
==========================================
+ Hits         9400     9405       +5     
- Misses        168      169       +1     
  Partials      113      113              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefan6419846 could you fix the two Ruff errors (2 fixable with the --fix option)? I do not have Ruff installed.

could you fix the two Ruff errors

Just use return None instead of return in these cases if it is a correct detection (as indicated in the help for the violation). If the detection is wrong, we would have to check manually anyway.

@stefan6419846 the return None is needed so we can remove RET503. Can you think of a way to reach this line, as otherwise code coverage is reduced.

I guess root = DictionaryObject({NameObject('/Next'): None}) could work, but AFAIK this branch should not be reachable with real PDF files as None is no PDF object. See #3209 (comment) as well.

I have marked it as pragma: no cover, as agree with you, I think is unreachable with real PDFs. Outlines are conceptually not difficult, and maybe a refactor of them may be useful.